Test for valid (non-null) socket @ws in Client.reconnect() before @ws.cl... #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….close() to avoid system failure on disabled bot
|
Hi, I reckon this update may be necessary to elegantly manage this exception. Given the trace for the call (see above image) I'm unable to trap and manage the exception from the caller |
|
+1. Also, should this check be made on the disconnect method? |
grantmd
added a commit
that referenced
this pull request
May 29, 2015
Test for valid (non-null) socket @ws in Client.reconnect() before @ws.cl...
aoberoi
added a commit
to aoberoi/node-slack-sdk
that referenced
this pull request
Mar 20, 2019
tests that when propogateErrors is used, no error is emitted
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for valid (non-null) socket @ws in Client.reconnect() before @ws.close() to avoid system failure if the bot is disabled